Unescape single quotes in Magento translation files #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signle quotes have to be escaped in PHP when label is wrapped in '' however in csv it's not needed and causes that some labels are not translated. Fixes OpenMage#27
LeeSaferite
added a commit
that referenced
this pull request
Oct 28, 2015
Unescape single quotes in Magento translation files
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Dec 6, 2017
Single quotes have to be escaped in PHP when label is wrapped in '' however in csv it's not needed and causes that some labels are not translated. Fixes OpenMage#27
edannenberg
added a commit
to edannenberg/magento-lts
that referenced
this pull request
Dec 6, 2017
The upstream merges for some 1.9.3.x releases introduced a few inconsistencies: * cms_generate_breadcrumbs event is fired twice * related to the above dd41230 is applied to wrong code block * few locale .csv have now escaped single quote entries along with the entries where those got removed in OpenMage#46 * OpenMage#21 got reverted at some point * var/package dir has 5 obsolete xml files * slightly different configuration in Sales, SalesRule and Tax config.xml * Mage_SalesRule_Model_Validator is outdated compared with latest from 1.9.3.7
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 28, 2018
Single quotes have to be escaped in PHP when label is wrapped in '' however in csv it's not needed and causes that some labels are not translated. Fixes OpenMage#27
colinmollenhour
pushed a commit
that referenced
this pull request
Mar 9, 2018
The upstream merges for some 1.9.3.x releases introduced a few inconsistencies: * cms_generate_breadcrumbs event is fired twice * related to the above dd41230 is applied to wrong code block * few locale .csv have now escaped single quote entries along with the entries where those got removed in #46 * #21 got reverted at some point * var/package dir has 5 obsolete xml files * slightly different configuration in Sales, SalesRule and Tax config.xml * Mage_SalesRule_Model_Validator is outdated compared with latest from 1.9.3.7
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Jul 17, 2018
Single quotes have to be escaped in PHP when label is wrapped in '' however in csv it's not needed and causes that some labels are not translated. Fixes OpenMage#27
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Sep 19, 2018
Single quotes have to be escaped in PHP when label is wrapped in '' however in csv it's not needed and causes that some labels are not translated. Fixes OpenMage#27
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 14, 2019
Single quotes have to be escaped in PHP when label is wrapped in '' however in csv it's not needed and causes that some labels are not translated. Fixes OpenMage#27
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Apr 1, 2019
Single quotes have to be escaped in PHP when label is wrapped in '' however in csv it's not needed and causes that some labels are not translated. Fixes OpenMage#27
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
Single quotes have to be escaped in PHP when label is wrapped in '' however in csv it's not needed and causes that some labels are not translated. Fixes OpenMage#27
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
Single quotes have to be escaped in PHP when label is wrapped in '' however in csv it's not needed and causes that some labels are not translated. Fixes OpenMage#27
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
Single quotes have to be escaped in PHP when label is wrapped in '' however in csv it's not needed and causes that some labels are not translated. Fixes OpenMage#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signle quotes have to be escaped in PHP when label is wrapped in ''
however in csv it's not needed and causes that some labels are not translated.
Fixes #27